Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

[feat] Add serve #399

Merged
merged 33 commits into from
Jun 11, 2021
Merged

[feat] Add serve #399

merged 33 commits into from
Jun 11, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Jun 11, 2021 •
edited
Loading

What does this PR do?

This PR add serve functionalities to Flash.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Jun 11, 2021 •
edited
Loading

Hello @tchaton! Thanks for updating this PR.

Line 702:25: W503 line break before binary operator
Line 703:25: W503 line break before binary operator
Line 878:13: W503 line break before binary operator

Comment last updated at 2021-06-11 16:52:58 UTC

@codecov
Copy link

codecov bot commented Jun 11, 2021 •
edited
Loading

Codecov Report

Merging #399 (e39293c) into master (5552a78) will decrease coverage by 5.04%.
The diff coverage is 76.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
- Coverage   89.82%   84.78%   -5.05%     
==========================================
  Files          80      109      +29     
  Lines        4217     6591    +2374     
==========================================
+ Hits         3788     5588    +1800     
- Misses        429     1003     +574
Flag Coverage Δ
unittests 84.78% <76.48%> (-5.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/serve/dag/visualize.py 20.93% <20.93%> (ø)
flash/__init__.py 88.88% <33.33%> (-11.12%) ⬇️
flash/core/serve/interfaces/http.py 40.50% <40.50%> (ø)
flash/core/serve/core.py 41.35% <41.35%> (ø)
flash/core/serve/execution.py 41.72% <41.72%> (ø)
flash/core/serve/composition.py 43.66% <43.66%> (ø)
flash/core/serve/utils.py 44.82% <44.82%> (ø)
flash/core/serve/interfaces/models.py 45.58% <45.58%> (ø)
flash/core/model.py 80.68% <46.42%> (-6.86%) ⬇️
flash/core/data/process.py 85.20% <57.69%> (-3.64%) ⬇️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5552a78...e39293c. Read the comment docs.

@tchaton tchaton marked this pull request as ready for review June 11, 2021 16:09
luiscape
luiscape reviewed Jun 11, 2021
View reviewed changes
Copy link

@luiscape luiscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The major change I suggest is on the naming of FlashServeModel to just Serve. It's more elegant and in-line with other project naming conventions, i.e. Task.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
flash/core/data/batch.py Show resolved Hide resolved
@tchaton tchaton merged commit 4384e4a into master Jun 11, 2021
@tchaton tchaton deleted the des branch June 11, 2021 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luiscape luiscape luiscape left review comments

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@carmocca carmocca Awaiting requested review from carmocca

@edenlightning edenlightning Awaiting requested review from edenlightning

@justusschock justusschock Awaiting requested review from justusschock

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tchaton @pep8speaks @luiscape